Details
-
Task
-
Resolution: Done
-
P1: Critical
-
None
-
-
Qt6_Foundation_ Sprint 1
Description
In case of QtNetwork the problem mostly occurs in error handling: a signal has a very generic name 'error', and then the getter (which returns the error that also was reported by the signal) has the same name. The safest approach is to rename the getter. Changing the signal's name would silently break the code that still would compile and later fail to report errors at run-time. For each class modified we'd have to update tests, documentation and examples. Classes in questions are:
- QLocalSocket
- QAbstractSocket
- QNetworkReply
- QSslSocket
Attachments
Issue Links
- relates to
-
QTBUG-80906 Improve signal signatures to avoid qOverloadOf in QtCore
- Closed
For Gerrit Dashboard: QTBUG-80369 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
285791,8 | QLocalSocket - deprecate ambiguous 'error' overloads | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
285915,2 | QWebSocket - do not use deprecated member-function | dev | qt/qtwebsockets | Status: MERGED | 0 | 0 |
286089,10 | QAbstractSocket: deprecate 'error' member-function | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
286220,5 | QSslSocket: deprecate sslErrors() getter | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
286259,4 | QNetworkReply: deprecate the 'error' getter | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
286533,2 | QWebSocket - do not use deprecated member-function | 5.15 | qt/qtwebsockets | Status: MERGED | +2 | 0 |
286584,4 | qtlocation: remove uses of the deprecated member-function | 5.15 | qt/qtlocation | Status: MERGED | +2 | 0 |
286592,1 | qtlocation: remove uses of the deprecated member-function | 5.15 | qt/qtlocation | Status: ABANDONED | 0 | 0 |
286612,2 | Replace deprecate QNetworkReply::error() call | 5.15 | qt/qt3d | Status: MERGED | +2 | 0 |
286614,2 | Use networkError instead of error | 5.15 | qt/qtdoc | Status: MERGED | +2 | 0 |
286615,2 | Use QNetworkReply::networkError() instead of simple error() | 5.15 | qt/qtnetworkauth | Status: MERGED | +2 | 0 |
286618,2 | Use QNetworkReply::networkError() instead of deprecated error() | 5.15 | qt/qtxmlpatterns | Status: MERGED | +2 | 0 |
286685,2 | Use QNetworkReply::networkError() instead of deprecated error() | 5.15 | qt/qtwinextras | Status: MERGED | +2 | 0 |
286829,5 | QtNetwork: remove deprecated ambiguous overloads | dev | qt/qtbase | Status: DEFERRED | -1 | 0 |