Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-80479

Remote object compiler produces code cppcheck does not like

    XMLWordPrintable

    Details

    • Type: Suggestion
    • Status: Reported
    • Priority: Not Evaluated
    • Resolution: Unresolved
    • Affects Version/s: 5.13.2
    • Fix Version/s: None
    • Component/s: Remote Objects
    • Labels:
      None
    • Platform/s:
      Linux/X11

      Description

      The generated code causes these cppcheck errors, the attach patch for repc  fixes this.

      license/lib/rep_LicenseState_replica.h:48:10: warning: Virtual function 'initialize' is called from constructor 'LicenseStateReplica()' at line 29.
      Dynamic binding is not used. [virtualCallInConstructor]
         void initialize() override
              ^
      license/lib/rep_LicenseState_replica.h:29:54: note: Calling initialize
         LicenseStateReplica() : QRemoteObjectReplica() { initialize(); }
                                                          ^
      license/lib/rep_LicenseState_replica.h:48:10: note: initialize is a virtual function
         void initialize() override
              ^
      license/lib/rep_NetworkLicense_replica.h:59:10: warning: Virtual function 'initialize' is called from constructor 'NetworkLicenseReplica()' at line
      38. Dynamic binding is not used. [virtualCallInConstructor]
         void initialize() override
              ^
      license/lib/rep_NetworkLicense_replica.h:38:56: note: Calling initialize
         NetworkLicenseReplica() : QRemoteObjectReplica() { initialize(); }
                                                            ^
      license/lib/rep_NetworkLicense_replica.h:59:10: note: initialize is a virtual function
         void initialize() override
              ^
      license/lib/rep_LicenseState_replica.h:42:5: style: Class 'LicenseStateReplica' has a constructor with 1 argument that is not explicit. [noExplicitC
      onstructor]
         LicenseStateReplica(QRemoteObjectNode *node, const QString &name = QString())
         ^
      license/lib/rep_NetworkLicense_replica.h:53:5: style: Class 'NetworkLicenseReplica' has a constructor with 1 argument that is not explicit. [noExpli
      citConstructor]
         NetworkLicenseReplica(QRemoteObjectNode *node, const QString &name = QString())

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            bstottle Brett Stottlemyer
            Reporter:
            bobstaff147 Bob Stafford
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes