Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
-
-
8
-
8341a3f435cdbcdda25d67f504ca630d285faa63 (qt/qtwebsockets/dev)
-
Team 2 Foundation_Sprint 46, Team 2 Foundation_Sprint 47, Team 2 Foundation_Sprint 48
Description
QWebSockets has its own self-rolled HTTP header-parser and various work has been put into improving it over the years.
We should look into getting rid of the self-rolled parser and instead re-use the parser used in the QNAM machinery (declared in qtbase\src\network\access\qhttpnetworkreply_p.h). This might require some work to make QNAM's parser more independent.
Attachments
Issue Links
- relates to
-
QTBUG-48184 QWebSocketServer disconnects a client if HTTP handshake arrives in multiple TCP segments
- Closed
-
QTBUG-38739 Provide more robust checking of illegal HTTP field values
- Closed
For Gerrit Dashboard: QTBUG-80700 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
359601,11 | Reuse qtbase's HTTP header parser to avoid a reinvented wheel | dev | qt/qtwebsockets | Status: MERGED | +2 | 0 |
360130,3 | Export QHttpNetworkReply private to permit it to be used by websockets | dev | qt/qtbase | Status: MERGED | +2 | 0 |
381347,11 | Add more verification when parsing http headers and add tests | dev | qt/qtbase | Status: MERGED | +2 | 0 |