Details
-
Type:
Task
-
Status: Closed
-
Priority:
P2: Important
-
Resolution: Done
-
Affects Version/s: 6.0
-
Fix Version/s: 6.0
-
Component/s: Qt RHI, Quick: SceneGraph
-
Labels:None
-
Commits:f02a6c040990e68d3fda1294499fcc956dfdd599 (qt/qtdeclarative/dev)
Description
qsgbatchrenderer.cpp comes with a QMatrix4x4_Accessor struct, which is then used with reinterpret_casts of QMatrix4x4:
struct QMatrix4x4_Accessor
{
float m[4][4];
int flagBits;
static bool isTranslate(const QMatrix4x4 &m) { return ((const QMatrix4x4_Accessor &) m).flagBits <= 0x1; }
static bool isScale(const QMatrix4x4 &m) { return ((const QMatrix4x4_Accessor &) m).flagBits <= 0x2; }
static bool is2DSafe(const QMatrix4x4 &m) { return ((const QMatrix4x4_Accessor &) m).flagBits < 0x8; }
};
This is only there because QMatrix4x4::flagBits is private. Figure out an alternative, less hackish way to achieve the same.
Attachments
Issue Links
- relates to
-
QTBUG-79268
Purge direct OpenGL code path in Qt Quick
-
- Closed
-
| For Gerrit Dashboard: QTBUG-82670 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 302188,3 | Remove QMatrix4x4_Accessor hack | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
| 302189,3 | Enable the scenegraph to remove its QMatrix4x4_Accessor hack | dev | qt/qtbase | Status: MERGED | +2 | 0 |