Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-82864

Q_ATOMIC_INT64_FETCH_AND_ADD_IS_ALWAYS_NATIVE and "friends" not defined correctly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P4: Low
    • 5.15.0 Beta2
    • 5.12.5
    • Core: Other
    • None
    • Windows
    • d55dad94f984333c11a7f01fbd5d8c07e405129f (qt/qtbase/5.15)

    Description

      In qatomic_cxx11.h, line 190 the code reads:

      #if QT_CONFIG(std_atomic64)
      template<> struct QAtomicOpsSupport<8> { enum

      { IsSupported = 1 }

      ; };

      1. define Q_ATOMIC_INT64_IS_SUPPORTED
      2. if ATOMIC_LLONG_LOCK_FREE == 2
      3. define Q_ATOMIC_INT16_REFERENCE_COUNTING_IS_ALWAYS_NATIVE
      4. define Q_ATOMIC_INT16_TEST_AND_SET_IS_ALWAYS_NATIVE
      5. define Q_ATOMIC_INT16_FETCH_AND_STORE_IS_ALWAYS_NATIVE
      6. define Q_ATOMIC_INT16_FETCH_AND_ADD_IS_ALWAYS_NATIVE

      ...

      Defining macros for 16 bits instead of the 64 bits macros.

      Seems like a typical copy & paste bug.

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            thiago Thiago Macieira
            cmendes Carlos Augusto Mendes
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes