Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-83336

Typing error in commit Fix light attenuation for ES 2

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P1: Critical
    • None
    • 5.12, 5.13
    • Qt3D
    • None

    Description

      A typing error has crept in commit :

      Change-Id: I95c64c150e0c4060374467942a2973b7687a88ca

      error:

      OpenGLShader::compile(Fragment): 0:69(5): error: `light' undeclared
      0:69(5): error: type mismatch
      0:69(5): error: operands of `!=' must have the same type
      0:70(5): error: `light' undeclared
      0:70(5): error: type mismatch
      0:70(5): error: operands of `!=' must have the same type
      0:102(5): error: `light' undeclared
      0:102(5): error: type mismatch
      0:102(5): error: operands of `!=' must have the same type
      0:103(5): error: `light' undeclared
      0:103(5): error: type mismatch
      0:103(5): error: operands of `!=' must have the same type
      

      reason:

      light is used instead of lights in phong.inc.frag100:

      if (lights[0].constantAttenuation != 0.0
       || light[0].linearAttenuation != 0.0
       || light[0].quadraticAttenuation != 0.0) {
       
      if (lights[1].constantAttenuation != 0.0
       || light[1].linearAttenuation != 0.0
       || light[1].quadraticAttenuation != 0.0) {

       

      Attachments

        For Gerrit Dashboard: QTBUG-83336
        # Subject Branch Project Status CR V

        Activity

          People

            seanharmer Sean Harmer
            sist Simon Steindl
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes