Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-84461

gc_sections needs to be propagated from Core to other modules / executables in CMake configs

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build System: CMake
    • Labels:

      Description

      There are a few parts to this:

      1) It looks like gc_sections is a public feature, and thus consumers of Core need the same flags as set by mkspecs/features/gc_sections.prf. At least that's what I saw when calling qmake -d on lrelease.

      2) Currently qt_internal_add_link_flags_gc_sections only sets link flags, whereas it should also set compile flags per specific compiler / target.

      This was discovered while investigating lrelease segfaults in cmake static builds at

      https://codereview.qt-project.org/c/qt/qttranslations/+/301471

      and the fix at

      https://codereview.qt-project.org/c/qt/qtbase/+/301837

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              alexandru.croitor Alexandru Croitor
              Reporter:
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes