Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-82335 Implement proper Tone-mapping logic
  3. QTBUG-85146

Assure textures are in linear color space when needed

    XMLWordPrintable

    Details

    • Type: Technical task
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Fix Version/s: 6.0.0
    • Component/s: Quick: 3D
    • Labels:
      None
    • Sprint:
      Qt Quick 3D - Week 19/20, Qt Quick 3D - 33 - 34, Qt Quick 3D - 35 - 36

      Description

      To facilitate correct rendering all color data must be in linear color space in the renderer.  This does not mean however that all textures should have their color data corrected.

      Qt and Qt Quick does provide information about what color space a source image is in (provided the user doesn't provide an incorrect suggestion).  For example when loading a user provided texture it is possible to use:

      https://doc.qt.io/qt-5/qimage.html#colorSpace

      to determine which color space the image is in.  If an image containing color data needs to be corrected we can flag it as such, and either convert it before upload, or perform some translation before using the data in the shader code.

      All images contain color data, but usage matters.  For example a texture that contains normal map data should not be converted, but a diffuse map should be.  The same goes for formats like Metallic/Roughness/AO, which should not be corrected.  Image data that will be be used as color in fragment shaders should be in linear space.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            janichol Andy Nichols
            Reporter:
            janichol Andy Nichols
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 minutes
                3m
                Remaining:
                Remaining Estimate - 3 minutes
                3m
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Gerrit Reviews

                  There are no open Gerrit changes