Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-85475

Use media::AudioManager::GetGlobalAppName for MPRIS integration

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Done
    • P2: Important
    • None
    • None
    • WebEngine
    • None
    • 946516b70549629dc9108473a9c34c14a36126ab (qt/qtwebengine-chromium/80-based) f3bf66c05bf36f1024cc2e916ef80a63da83cab3 (qt/qtwebengine-chromium/83-based) 1c5dd09357ac67495cf1ab288d1cd70093946c69 (qt/qtwebengine-chromium/87-based)

    Description

      With the fix for QTBUG-85363, the proper application name is now shown in Pulseaudio. However, Chromium's MPRIS integration still seems to hardcode the application name as Chrome/Chromium:

      #if BUILDFLAG(GOOGLE_CHROME_BRANDING)
        set_property("Identity", DbusString("Chrome"));
      #else
        set_property("Identity", DbusString("Chromium"));
      #endif
      

      Given that it's related to audio as well, I suppose this could use media::AudioManager::GetGlobalAppName instead of hardcoding the name as well? Not sure if a patch for that should be in QtWebEngine or Chromium upstream, though?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            allan.jensen Allan Sandfeld Jensen
            the compiler Florian Bruhin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes