Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-85992

Make optimization flags consistent for Release and RelWithDebInfo in relation to qmake

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • None
    • 6.0.0
    • Build System: CMake

    Description

      As per https://gitlab.kitware.com/cmake/cmake/-/issues/20812

      1. CMake has some weird flag defaults for RelWithDebInfo on Windows, where it includes /INCREMENTAL which is a development feature, and increases binary size and is cache unfriendly.
      2. RelWithDebInfo on Windows also includes /Ob1, which disables automatic inlining
      3. We should use -O2 for both Release and RelWithDebInfo configs. With GCC / AppleClang, Release defaults to -O3, while RelWithDebInfo to -O2.
      4. In general we should make RelWithDebInfo be equal to Release + the debug generation flag.

      We aim to use RelWithDebInfo for Packaging configurations, so it's important to get them right.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-86866 Fix optimization flags used for Core and Gui

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-83929 Scan through and port all defines, compile and link flags from mkspecs/foo/bar.conf files to relevant Qt::Platform or Qt::PlatformCommonInternal targets

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-89821 Re-running CMake causes Android builds to recompile everything when building Qt itself

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-85992
          # Subject Branch Project Status CR V
          310545,13 CMake: Adjust compiler flag optimizations to qmake mkspec ones dev qt/qtbase Status: MERGED +2 0
          310600,5 CMake: Add /OPT:REF flag when building Qt on Windows dev qt/qtbase Status: MERGED +2 0
          329068,5 Prevent compiler and linker flags from growing every cmake run dev qt/qtbase Status: MERGED +2 0

          Activity

            People

              alexandru.croitor Alexandru Croitor
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes