Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-86703

Qt5Compat QRegExp auto-test failing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 6.0 (Next Major Release)
    • Fix Version/s: 6.0.0 Beta1
    • Component/s: Core: Other
    • Labels:
      None
    • Platform/s:
      All

      Description

      Commit 45ed28a9d3790707b18798454d976f3a818a7740 removes QRegExp from QVariant and introduces the failing auto-test. The failing auto-test is tst_QRegExp::datastream2(). The issue is not obvious at first, because the above test was introduced with another one, tst_QRegExp::datastream(), which is run before the datastream2(). If this is the case, the test passes, if the test function is run alone without executing another test if fails right away.

      After QRegExp was moved to Qt5Compat the above was still unnoticed up until commit 14dece57e9d63fe4a1be5e8a1fc1816c4a9b7fe6 which remaps QMetaType ids to create more space for builtin types. This finally breaks the tst_QRegExp::datastream2(), independent if run stand-alone or in sequence with tst_QRegExp::datastream()

      For the moment the auto-test was disabled, but probably needs to be fixed anyway before Qt6 release.

      d:\work\2019-x64\qt5compat\tests\auto\core5\text\qregexp>debug\tst_qregexp.exe datastream2
      ********* Start testing of tst_QRegExp *********
      Config: Using QtTest library 6.0.0, Qt 6.0.0 (x86_64-little_endian-llp64 shared (dynamic) debug build; by MSVC 2019)
      PASS   : tst_QRegExp::initTestCase()
      FAIL!  : tst_QRegExp::datastream2() Compared values are not the same
         Actual   (buffer.data().left(5)): "\x00\x00\x00\x00\x01"
         Expected (data.left(5))         : "\x00\x00\x00\x1B\x01"
      D:\work\qt\qt5compat\tests\auto\core5\text\qregexp\tst_qregexp.cpp(1674) : failure location
      FAIL!  : tst_QRegExp::datastream2() Compared values are not the same
         Actual   (buffer.data().left(5)): "\x00\x00\x00\x00\x01"
         Expected (data.left(5))         : "\x00\x00\x00\x1B\x01"
      D:\work\qt\qt5compat\tests\auto\core5\text\qregexp\tst_qregexp.cpp(1674) : failure location
      PASS   : tst_QRegExp::cleanupTestCase()
      Totals: 2 passed, 2 failed, 0 skipped, 0 blacklisted, 3ms
      ********* Finished testing of tst_QRegExp *********
      

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            laknoll Lars Knoll
            Reporter:
            heimrich Karsten Heimrich
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes