Details
-
Bug
-
Resolution: Done
-
P2: Important
-
5.15.0, 5.15.1
-
None
-
Windows and Linux, probably other platforms too
-
b39b018f4a54252ee7a9ffada6d0f05f5896baaf (qt/qtbase/dev) 404b0cc60a65dedbcdc3417f567d9b21c55c359b (qt/tqtc-qtbase/tqtc/lts-5.15)
Description
After inserting a new tab between the current tab and the last tab, the last tab is incorrectly styled. See attached screenshot.
Checked under a debugger, it appears that the internal state is not updated in this case. Specifically, QTabBarPrivate::lastVisible is not updated to reflect the index of the last visible tab. This results in the wrong tab styled, as if it was the last instead.
It looks like the regression was introduced by this change, https://codereview.qt-project.org/c/qt/qtbase/+/255141
Attachments
| For Gerrit Dashboard: QTBUG-86898 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 315309,3 | QTabBar test: refactor: extract checkPositions helper function | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 315310,3 | QTabBar: update index of last visible tab in insertTab | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 322870,3 | QTabBar test: refactor: extract checkPositions helper function | 5.15 | qt/qtbase | Status: MERGED | 0 | 0 |
| 322871,2 | QTabBar: update index of last visible tab in insertTab | 5.15 | qt/qtbase | Status: MERGED | 0 | 0 |
| 329220,3 | QTabBar: update index of last visible tab in insertTab | tqtc/lts-5.15 | qt/tqtc-qtbase | Status: MERGED | -1 | 0 |
| 329544,2 | QTabBar test: refactor: extract checkPositions helper function | tqtc/lts-5.15 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |