Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-8766

ProxyModel::rowCount()'s parent parameter should have a default value.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 4.7.0
    • 4.6.2
    • Widgets: Itemviews
    • None
    • 5ecdb1a77b06956d3475f7d19dc573815233595a

    Description

      QAbstractItemModel::rowCount() has a default value for the parent parameter:
      http://doc.trolltech.com/4.6/qabstractitemmodel.html#rowCount
      but the ProxyModel::rowCount() override does not have the default parameter value:
      http://doc.trolltech.com/4.6/qproxymodel.html#rowCount

      This makes it slightly harder to use the QAbstractItemModel API polymorphically.

      I know that default parameter values are awkward with virtual methods, but I see that other derived classes do keep the default parameter values, so fixing this would make Qt more consistent.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            vfm Thierry Bastian (closed Nokia identity) (Inactive)
            murrayc Murray Cumming
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes