Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-87664

Adjust behavior of add_qt_gui_executable / qt_add_executable as per API review

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 6.0
    • Build System: CMake

    Description

      Resulted from https://codereview.qt-project.org/c/qt/qtbase/+/317353/1/src/corelib/Qt6CoreMacros.cmake#449

      Things to implement:

      1) Remove WIN32 MACOSX_BUNDLE properties.
      Users should opt-in manually via set_target_properties.
      This most likely implies that we'll need to regenerate all examples to set those where appropriate.

      2) remove Gui linkage
      I don't expect many changes needed in the examples to adapt to this.

      3) Remove calling of qt6_generate_win32_rc_file
      Not sure about the impact of this yet.

      Attachments

        Issue Links

          resulted from

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-86827 Document new Qt 6 CMake API

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-87664
          # Subject Branch Project Status CR V
          318953,3 CMake: Make qt_add_executable more minimalistic dev qt/qtbase Status: MERGED +2 0
          318954,3 CMake: pro2cmake: Handle CONFIG+=console app_bundle in examples dev qt/qtbase Status: MERGED +2 0
          318955,3 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtbase Status: MERGED +2 0
          318963,3 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtdeclarative Status: MERGED +2 0
          318970,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtnetworkauth Status: MERGED +2 0
          318972,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qt5compat Status: MERGED +2 0
          318973,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtdoc Status: MERGED +2 0
          318975,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtquick3d Status: MERGED +2 0
          318976,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtquickcontrols2 Status: MERGED +2 0
          318977,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qttools Status: MERGED +2 0
          318978,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtwayland Status: MERGED +2 0
          318980,1 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtmqtt Status: DEFERRED +2 0
          318981,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtopcua Status: MERGED +2 0
          318982,3 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtwebsockets Status: MERGED +2 0
          318983,1 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtremoteobjects Status: DEFERRED 0 0
          318985,1 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtwinextras Status: DEFERRED 0 0
          318987,1 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtactiveqt Status: DEFERRED 0 0
          318988,2 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtcoap Status: MERGED +2 0
          318989,1 CMake: Regenerate examples to set the WIN32_EXECUTABLE property dev qt/qtconnectivity Status: DEFERRED 0 0

          Activity

            People

              alexandru.croitor Alexandru Croitor
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes