Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
None
-
6.0
-
aa6ad154243b514cd55b10af64b72f4fa3d1cd02 (qt/qtbase/dev)
Description
In mkspecs/features/qt_configure.prf there's
defineReplace(qtIsFeatureEnabled) { enable = $$eval($${currentConfig}.features.$${1}.enable) !isEmpty(enable) { $$qtConfEvaluate($$enable): \ return(true) } else { equals(config.input.$${1}, "yes"): \ return(true) } return(false) }
so if input.foo is set to true, feature foo will be considered enabled.
This happens for qmake's 'xcb-native-painting' command line switch which basically sets input.xcb-native-painting=yes, thus enabling the feature.
We are currently lacking this in CMake feature system.
If a user uses the configure script and passes -xcb-native-painting, that will be translated by the script to -DFEATURE_xcb_native_painting=ON
But if a user uses cmake directly, and passes -DINPUT_xcb_native_painting=ON, that will be ignored. If we want parity with qmake, we should consider implementing the same behavior at CMake feature level.
Attachments
Issue Links
- relates to
-
QTBUG-88166 -DFEATURE_opengl_desktop=ON won't disable opengl_dynamic
- Closed
For Gerrit Dashboard: QTBUG-87755 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
320185,4 | CMake: Add handling of user-defined INPUT_foo cache variables | dev | qt/qtbase | Status: MERGED | +2 | 0 |
320384,7 | CMake: Rework INPUT_ variables handling | dev | qt/qtbase | Status: MERGED | +2 | 0 |