Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-87775

Passing INTERNAL_MODULE to qt_internal_add_module should only create a single Qt::FooPrivate target

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reported
    • Priority: P3: Somewhat important
    • Resolution: Unresolved
    • Affects Version/s: 6.0 (Next Major Release)
    • Fix Version/s: None
    • Component/s: Build System: CMake
    • Labels:

      Description

      Resulted from discussion at https://codereview.qt-project.org/c/qt/qtbase/+/318453/2/src/entrypoint/CMakeLists.txt#12

      With qmake, marking a qt module with CONFIG += internal_module ends up creating a single qt_lib_foo_private.pri file, without a qt_lib_foo.pri counterpart.

      In CMake, marking a module as INTERNAL_MODULE ends up creating 2 targets: Qt::Foo and Qt::FooPrivate.
      It's currently done this way because we realised the required changes too late in the CMake port timeframe, and it was easier to place all relevant include dirs, etc on the main non-Private target.

      We should align with qmake, and create only the Qt::FooPrivate target.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              alexandru.croitor Alexandru Croitor
              Reporter:
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes