Details
-
Suggestion
-
Resolution: Done
-
P3: Somewhat important
-
None
-
None
-
27d96b4789b98587e64642bf7bd6ef5f3a07e174 (qt/qtbase/dev)
Description
To use QtTest the correct include is QTest or QtTest/QTest.
All other things being equal, it's NOT correct to use QtTest or QtTest/QtTest, as those are the module-wide includes, which recursively include all of QtCore plus other files (e.g. QtGui stuff).
There are as of now some 600+ occurences of QtTest inclusions in qtbase tests alone.
- Has anyone tried to do a mass search and replace and compare the build times?
- How about having the sanity bot automatically flag any usage of module-wide include?
Attachments
For Gerrit Dashboard: QTBUG-88831 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
323799,33 | Replace QtTest headers with QTest | dev | qt/qtbase | Status: MERGED | +2 | 0 |
327801,3 | Replace QtTest headers with QTest | 6.0 | qt/qtbase | Status: ABANDONED | 0 | 0 |