Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-89186

Fix license attributions for src/3rdparty/glslang

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 6.0.0
    • Fix Version/s: 6.0.1, 6.1.0 Alpha
    • Component/s: Qt RHI
    • Labels:
      None
    • Commits:
      4e1806acc92a4155c64a628d10ac70d4b4973a55 (qt/qtshadertools/dev) 36ea6638342d4e56c8ae525a6aad9a877a31cf5b (qt/qtshadertools/6.0)

      Description

      Following files do have a copyright that is not one of the 2 standard ones:

      Khronos License

      • qtshadertools/src/3rdparty/glslang/SPIRV/spirv.hpp
      • qtshadertools/src/3rdparty/glslang/SPIRV/GLSL.std.450.h
      • qtshadertools/src/3rdparty/glslang/SPIRV/GLSL.ext.NV.h
      • qtshadertools/src/3rdparty/glslang/SPIRV/GLSL.ext.KHR.h
      • qtshadertools/src/3rdparty/glslang/SPIRV/GLSL.ext.EXT.h
      • qtshadertools/src/3rdparty/glslang/SPIRV/GLSL.ext.AMD.h
      • qtshadertools/src/3rdparty/glslang/glslang/MachineIndependent/gl_types.h

      Apache 2.0 License

      • qtshadertools/src/3rdparty/glslang/SPIRV/hex_float.h
      • qtshadertools/src/3rdparty/glslang/SPIRV/bitutils.h

      GNU General Public License v3.0 or later with Bison Exception 2.2

      • qtshadertools/src/3rdparty/glslang/glslang/MachineIndependent/glslang_tab.cpp.h
      • qtshadertools/src/3rdparty/glslang/glslang/MachineIndependent/glslang_tab.cpp

      Anyhow, qtshadertools/src/3rdparty/glslang/LICENSE.txt does imply that some (all?) of them are not needed / used:

      Bison was removed long ago. You can build glslang from the source grammar,
      using tools of your choice, without using bison or any bison files.

      Other parts, outside of glslang proper, include:

      • gl_types.h, only needed for OpenGL-like reflection, and can be left out of
        a parse and codegen project. See it for its license.
      • update_glslang_sources.py, which is not part of the project proper and does
        not need to be used.
      • the SPIR-V "remapper", which is optional, but has the same license as
        glslang proper
      • Google tests and SPIR-V tools, and anything in the external subdirectory
        are external and optional; see them for their respective licenses.

      Please remove the files, if necessary. Or document the additional licenses.

        Attachments

        For Gerrit Dashboard: QTBUG-89186
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            lagocs Laszlo Agocs
            Reporter:
            kkohne Kai Köhne
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes