Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-89545

CMake: on macOS (w/ framework build) the module includes the binary

    XMLWordPrintable

Details

    • macOS
    • b858704e1f (qt/qtbase/dev) b858704e1f (qt/tqtc-qtbase/dev) ed186bc202 (qt/qtbase/6.2) 48922a3ea2 (qt/qtbase/6.3) ed186bc202 (qt/tqtc-qtbase/6.2) 48922a3ea2 (qt/tqtc-qtbase/6.3) 48922a3ea2 (qt/tqtc-qtbase/6.3.0)

    Description

      With the structure of a .framework folder:

      35 Dec 15 12:15 QtConcurrent_debug -> Versions/Current/QtConcurrent_debug
Headers -> Versions/Current/Headers
Resources -> Versions/Current/Resources
Versions/
QtConcurrent -> Versions/Current/QtConcurrent

      We could see a build in QtHttpServer including QtConcurrent.framework/QtConcurrent (the symlink to the library) when doing:

      #include <QtConcurrent>

      And the log (at the end) shows that we put the root of the include folder in path:

      -I/Users/qt/work/install/lib/QtConcurrent.framework -I/Users/qt/work/install/lib/QtConcurrent.framework/Headers

      So we end up including the (symlink to the) binary in the top-level folder of the .framework and not the header in Headers as we would normally expect.

      https://testresults.qt.io/logs/qt-extensions/qthttpserver/fa0144be3663fe3f4683e6a61fe975ae8d3d8bab/MacOSMacOS_10_14x86_64MacOSMacOS_10_14x86_64Clangqtci-macos-10.14-x86_64-f695c4Sccache/d65067a96d450aa1e7abf563fbe40dd7240b9662/build_1608113680/log.txt.gz

      https://testresults.qt.io/coin/integration/qt-extensions/qthttpserver/tasks/web_qt-extensions_qthttpserver_1608113463832

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-101718 [REG 6.3.0beta2->beta3] quick3d/principledmaterial not launching on macOS

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-101775 Don't add framework directories as include paths

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-89545
          # Subject Branch Project Status CR V
          401088,4 CMake: Mitigate moc not finding correct headers in framework builds dev qt/qtbase Status: MERGED +2 0
          401211,2 CMake: Mitigate moc not finding correct headers in framework builds 6.2 qt/qtbase Status: MERGED +2 0
          401212,2 CMake: Mitigate moc not finding correct headers in framework builds 6.3 qt/qtbase Status: MERGED +2 0

          Activity

            People

              qtbuildsystem Qt Build System Team
              manordheim Mårten Nordheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes