Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-89942

Something is wrong with the way custom materials and effects parse comments

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 6.0.0
    • Fix Version/s: 6.0.1, 6.1.0 Alpha
    • Component/s: Quick: 3D
    • Labels:
      None
    • Commits:
      f08a937b782e544944f8fdfe26e7e54c50989c7f (qt/qtquick3d/dev) 66e8de19319e53bea00b8edfe9a3452e91cd06e2 (qt/qtquick3d/6.0)

      Description

          rgby2 = (temp2N + rgby2) * 0.5;
      /*--------------------------------------------------------------------------*/
      // (11)
          // compilier moves these scalar ops up to other cycles
          #if (FXAA_GREEN_AS_LUMA == 0)
      

      becomes

          rgby2 = (temp2N + rgby2) * 0.5;    #if (FXAA_GREEN_AS_LUMA == 0)
      

      which is not a problem for semicolon-separated statements but breaks directives like the #if

      Files pulled in via #include are not processed by this system (the content is just thrown in as-is), so this only becomes visible if one manages to have such lines in the main custom vertex or fragment shader file. One place where this became visible is when attempting to fold the fxaa .glsllib include file into the FXAA effect's fragment shader file.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            lagocs Laszlo Agocs
            Reporter:
            lagocs Laszlo Agocs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes