Details
-
Bug
-
Resolution: Done
-
P2: Important
-
6.0.0
-
None
-
f08a937b782e544944f8fdfe26e7e54c50989c7f (qt/qtquick3d/dev) 66e8de19319e53bea00b8edfe9a3452e91cd06e2 (qt/qtquick3d/6.0)
Description
rgby2 = (temp2N + rgby2) * 0.5; /*--------------------------------------------------------------------------*/ // (11) // compilier moves these scalar ops up to other cycles #if (FXAA_GREEN_AS_LUMA == 0)
becomes
rgby2 = (temp2N + rgby2) * 0.5; #if (FXAA_GREEN_AS_LUMA == 0)
which is not a problem for semicolon-separated statements but breaks directives like the #if
Files pulled in via #include are not processed by this system (the content is just thrown in as-is), so this only becomes visible if one manages to have such lines in the main custom vertex or fragment shader file. One place where this became visible is when attempting to fold the fxaa .glsllib include file into the FXAA effect's fragment shader file.
Attachments
For Gerrit Dashboard: QTBUG-89942 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
330568,6 | Move FXAA shader code to the effect itself | dev | qt/qtquick3d | Status: MERGED | +2 | 0 |
330601,2 | Move FXAA shader code to the effect itself | 6.0 | qt/qtquick3d | Status: MERGED | +2 | 0 |