[QTBUG-90395] FTBFS: qendian.h missing <limits> include - Qt Bug Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: P1: Critical
Resolution: Done
Affects Version/s: 5.15.2
Fix Version/s: 5.15.9, 6.0.1, 6.1.0 Alpha
Component/s: Core: Other
Labels:
None
Environment:
Fedora Rawhide

Platform/s:

All
Commits:
9c56d4da2ff631a8c1c30475bd792f6c86bda53c (qt/qtbase/dev) b2af6332ea37e45ab230a7a5d2d278f86d961b83 (qt/qtbase/6.0) 0afad46bb71b106780dd641de768a81d9f6c6a51 (qt/tqtc-qtbase/tqtc/lts-5.15)

Description

qendian.h uses std::numeric_limits but does not #include <limits>. As a result, any QT application using QtEndian fails to build with gcc11 (e.g. Fedora Rawhide) with a ton of errors like:

In file included from /usr/include/qt5/QtCore/qendian.h:44,
from /usr/include/qt5/QtCore/QtEndian:1,
from yet_another_qt_bug.cpp:2:
/usr/include/qt5/QtCore/qfloat16.h:300:7: error: 'numeric_limits' is not a class template
300 | class numeric_limits<QT_PREPEND_NAMESPACE(qfloat16)> : public numeric_limits<float>