Details
-
Task
-
Resolution: Fixed
-
P2: Important
-
None
-
None
-
None
-
13
-
Qt6_Foundation_Sprint 28, Qt6_Foundation_Sprint 29, Qt6_Foundation_Sprint 30, Qt6_Foundation_Sprint 31
Description
The QtRO tests for QAbstractItemModel are fragile: the root of the problem is that client requests don't know the shape of the response (list, tree, etc), so several client-server trips may be necessary and detecting when a QCOMPARE or QVERIFY can be made is difficult.
Review the tests and investigate whether the current approach can be improved. https://codereview.qt-project.org/c/qt/qtbase/+/302905 may be relevant.
Attachments
| For Gerrit Dashboard: QTBUG-90688 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 338652,5 | Use QAbstractItemModelReplica::multiData in benchmarks and tests | dev | qt/qtremoteobjects | Status: ABANDONED | 0 | 0 |
| 340805,4 | Add a helper class for waiting for model changes in tests | dev | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 340806,2 | Refactor the TestModelView test | dev | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 340807,2 | Simplify the WaitForDataChanged test-helper class | dev | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 340808,4 | Simplify the FetchData test-helper class | dev | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 341136,2 | Fix an error in TestModelView::testDataRemoval test | dev | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 343685,3 | Add a helper class for waiting for model changes in tests | 5.12 | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 343686,4 | Refactor the TestModelView test | 5.12 | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 343687,5 | Simplify the WaitForDataChanged test-helper class | 5.12 | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 343688,5 | Fix an error in TestModelView::testDataRemoval test | 5.12 | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 343689,5 | Simplify the FetchData test-helper class | 5.12 | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
| 343746,2 | Add a helper class for waiting for model changes in tests | tqtc/lts-5.15 | qt/tqtc-qtremoteobjects | Status: MERGED | +2 | 0 |
| 343747,3 | Refactor the TestModelView test | tqtc/lts-5.15 | qt/tqtc-qtremoteobjects | Status: MERGED | +2 | 0 |
| 343748,3 | Simplify the WaitForDataChanged test-helper class | tqtc/lts-5.15 | qt/tqtc-qtremoteobjects | Status: MERGED | +2 | 0 |
| 343749,2 | Fix an error in TestModelView::testDataRemoval test | tqtc/lts-5.15 | qt/tqtc-qtremoteobjects | Status: MERGED | +2 | 0 |
| 343750,3 | Simplify the FetchData test-helper class | tqtc/lts-5.15 | qt/tqtc-qtremoteobjects | Status: MERGED | +2 | 0 |