Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-90716

QGuiApplication::primaryScreen() not returning the correct screen if the user changes their main display.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.15.1, 5.15.2
    • Fix Version/s: 6.1.0 Alpha
    • Component/s: GUI: High-DPI
    • Labels:
      None
    • Platform/s:
      Windows
    • Commits:
      dafe9e23638c4fe272044fae91380a225e19193a (qt/qtbase/dev) 0cc492022cd90789f4d452880079f1bec7d70298 (qt/tqtc-qtbase/tqtc/lts-5.15)

      Description

      The issue is that the method primaryScreen on QGuiApplication assumes that the screen at index zero in QGuiApplicationPrivate::screen_list is always the primary screen.
      This is not the case if the user changes their primary screen while the Qt app is running.

      Steps:
      Qt app that opens a QWidget popup with the attribute Qt::WA_TranslucentBackground & window flag Qt::FramelessWindowHint set.
      User has a high dip multiple monitor setup, in my case (3840 x 2160 DPI 150%) x2.
      While the Qt app is running change the main display by using display settings.
      In the Qt app click the button to display the popup.
      End result is that the popup is transparent and the user can't see it.

      Testapp attached:

      Root cause:
      In the method QWindowsBackingStore::flush Qt needs to call the Win32 API UpdateLayeredWindowIndirect so the popup can be transparent.
      That API takes a dirty rect that is calculated with a frameOffset, the primary screen used to calculate that off set was incorrect, so the frameOffset is incorrect.
      And the result of this is that the popup is transparent.

      The fix:
      Whenever the main display changes update QGuiApplicationPrivate::screen_list so the new primary screen is always at index zero.
      But going by the comment in the monitorEnumCallback method in qwindowsscreen.cpp, it's sounds like this is expected?
      // QWindowSystemInterface::handleScreenAdded() documentation specifies that first
      // added screen will be the primary screen, so order accordingly.
      // Note that the side effect of this policy is that there is no way to change primaryhighlightsv
      // screen reported by Qt, unless we want to delete all existing screens and add them
      // again whenever primary screen changes.

      A another approach would be to update the method QGuiApplication::primaryScreen() to return the correct primary screen.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            sorvig Morten Sørvig
            Reporter:
            chrisog Chris O'Gorman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes