Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-90836

QtPositioning: verify and improve unit tests

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P2: Important
    • 6.2.0 FF
    • None
    • Positioning
    • None
    • 13
    • Qt6_Foundation_Sprint 27, Qt6_Foundation_Sprint 28

    Description

      • Currently most of the C++ unit tests use raw new/delete operations to create objects, which leads to memleaks if the tests fail. It makes debugging tests under ASAN or memcheck quite annoying. Makes sense to consistently use QScopedPointer or std::unique_ptr for such cases.
      • Most of declarative unit tests use both QtPositioning and QtLocation. It might be possible to separate this tests, so that declarative part of QtPositioning could be tested without compiling QtLocation. If separation is not possible, it might make sense to create new unit tests for such cases.
      • Some tests are added as qt_internal_add_executable instead of qt_internal_add_test. This prevents the test autodetection & execution with ctest.

      Attachments

        Issue Links

          is required for

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. QTBUG-88613 Migrate Qt Positioning to Qt 6

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              ivan.solovev Ivan Solovev
              ivan.solovev Ivan Solovev
              Maurice Kalinowski Maurice Kalinowski
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes