Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-91431

CommpareNotEqual misspelled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.15.2
    • Fix Version/s: 6.1.0 RC
    • Component/s: GUI: OpenGL
    • Labels:
      None
    • Commits:
      2cfbce4bc61fd1f450f221e6ce733753f6cabb0b (qt/qtbase/dev) 49c58510549370d22a1c0f9c9243bdff5c023d80 (qt/qtbase/6.1)

      Description

      https://code.qt.io/cgit/qt/qtbase.git/tree/src/opengl/qopengltexture.h?id=9d6ba110e8f98463d136fa97993db6d1968479c1#n553

              CommpareNotEqual    = 0x0205,   // GL_NOTEQUAL
      

      Commpare should be Compare. Sure, there's backwards compatibility to consider. Even if it is decided to not fix this, at least there will be a rejected issue for this that others can find in the future.

      I noticed this in PyQt5 5.15.3 (uses Qt 5.15.2) in Qt3DRender.QAbstractTexture.ComparisonFunction.CommpareNotEqual.  Also found a reference at the link below.

      https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/opengl/qopengltexture.cpp?h=5.15.2&id=40143c189b7c1bf3c2058b77d00ea5c4e3be8b28#n4376

      Anyways, maybe just checkout the full tree for a few different places where development will continue and grep -i commpare to try to catch them all.

        Attachments

        For Gerrit Dashboard: QTBUG-91431
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            lagocs Laszlo Agocs
            Reporter:
            altendky Kyle Altendorf
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes