Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-91717

QJSPrimitiveValue must not use std::variant

    XMLWordPrintable

    Details

    • Commits:
      9970ebb277db5f11c8a7e72099fdd056a6d8310c (qt/qtdeclarative/dev) 3908cf16c0c5dab125e53e028babbb9a479f371e (qt/qtdeclarative/6.1)

      Description

      In contrast to my initial estimate std::variant is still expensive if you don't use exceptions. We need to replace it with a tagged union. As it's public API we have to delay the 6.1 release for it.

        Attachments

        For Gerrit Dashboard: QTBUG-91717
        # Subject Branch Project Status CR V
        338335,6 Replace std::variant with tagged union in QJSPrimitiveValue dev qt/qtdeclarative Status: MERGED +2 0
        338695,2 Replace std::variant with tagged union in QJSPrimitiveValue 6.1 qt/qtdeclarative Status: MERGED +2 0

          Activity

            People

            Assignee:
            ulherman Ulf Hermann
            Reporter:
            ulherman Ulf Hermann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes