Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-91912

QSqlError has broken move semantics

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Not Evaluated
    • 6.6.0
    • 5.15, 6.0.0
    • SQL Support
    • d7607a463 (dev)

    Description

      QSqlError is a value type with broken move semantics. A value that's been moved-from via assignment operator will be valid (it will have the d-pointer of the assignee), while a value that's been moved from via move-construction will be invalid (d-pointer will be nullptr).

      Getters don't check the d-pointer for being a valid pointer. That is is ok as per QUIP-19.

      The class should generally use implicit sharing to avoid these inconsistencies.

      Attachments

        For Gerrit Dashboard: QTBUG-91912
        # Subject Branch Project Status CR V
        339387,3 QSqlError: protect against self-assignment dev qt/qtbase Status: MERGED +2 0
        468953,14 QSqlError: Make QSqlErrorPrivate implicitly shared dev qt/qtbase Status: MERGED +2 0

        Activity

          People

            mabrand Mark Brand
            vhilshei Volker Hilsheimer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes