Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-92033

Assistant not built in static Qt builds due to incorrect FEATURE_sql_sqlite condition

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 6.0.2, 6.1.0 Beta2
    • Fix Version/s: 6.1.1, 6.2.0 Alpha
    • Component/s: Build System: CMake
    • Labels:
    • Environment:

      static Qt

    • Technical Risk:
      Normal
    • Commits:
      fbc98a84e737ad543d8aca0c89edca132b86aa42 (qt/qttools/dev) 76094964825d94f750d698dbf3aca2c4fabf1d44 (qt/qttools/6.1)

      Description

      See https://codereview.qt-project.org/c/qt/qttools/+/304209/6/src/CMakeLists.txt#24

      The assistant subdirectory is not added if FEATURE_sql_sqlite is false and Qt is a static build.

      The FEATURE_sql_sqlite variable is never set in a per-repo build, because the feature is not exported on the Sql target. The sqldrivers/configure.cmake file is never associated to the Sql target, and thus none of the sqldrivers features are ever recorded / exported.
      Presumably this was on purpose, because the sqldrivers folder is meant to build as a standalone project as well.

      The sql plugin features are not exported in qmake Qt 5.15 builds as well.

      We should find what's the appropriate CMake condition for qmake's 'contains(QT_PLUGINS, qtsqlite) , because checking for the feature currently worn't work.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            jbornema Joerg Bornemann
            Reporter:
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes