Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-92257

qt5.git submodules are ignored in top-level build

    XMLWordPrintable

Details

    • 1397f8c123ab493639f8ccdd5347fb52c2adee11 (qt/qt5/dev) 6a85c577bbfcd7b471d45d0e0cee612a9af4b153 (qt/qt5/6.1)

    Description

      Under certain circumstances, the logic to order submodules by dependencies in qt5.git fails, resulting in some leaf modules not being configured or built.

      THis is reproducible for me when checking out the 6.1 branch of a normal qt5.git checkout:

      git clone git://code.qt.io/qt/qt5.git
cd qt5 && git checkout 6.1
perl init-repository
git submodule foreach "(git checkout 6.1 || git checkout master) && git pull"

      When then running configure, e.g. qt3d, but also other modules are completely ignored. This can be already seen by the 'Check dependencies ...' calls

      Check dependencies of 'qtbase'
Check dependencies of 'qtshadertools'
Check dependencies of 'qtsvg'
Check dependencies of 'qtdeclarative'
Check dependencies of 'qtquick3d'
Check dependencies of 'qtimageformats'
Check dependencies of 'qtquickcontrols2'
Check dependencies of 'qtquicktimeline'
Check dependencies of 'qtscxml'
Check dependencies of 'qtactiveqt'
Check dependencies of 'qttools'
Check dependencies of 'qttranslations'
Check dependencies of 'qtvirtualkeyboard'
Check dependencies of 'qtwayland'
Check dependencies of 'qtqa'

      Running cmake with --log-level=DEBUG hints towards qt_internal_parse_dependencies :

      -- qt_internal_parse_dependencies sorted qt3d;qt5compat;qtactiveqt;qtbase;qtcharts;qtcoap;qtdatavis3d;qtdeclarative;qtdoc;qtimageformats;qtlottie;qtmqtt;qtnetworkauth;qtopcua;qtqa;qtquick3d;qtquickcontrols2;qtquicktimeline;qtscxml;qtshadertools;qtsvg;qttools;qttranslations;qtvirtualkeyboard;qtwayland: qtbase;qtshadertools;qtsvg;qtdeclarative;qtquick3d;qtimageformats;qtquickcontrols2;qtquicktimeline;qtscxml;qtactiveqt;qttools;qttranslations;qtvirtualkeyboard;qtwayland;qtqa

      This only happens though if one checks out the individual 6.1 branches...

      Attachments

        For Gerrit Dashboard: QTBUG-92257
        # Subject Branch Project Status CR V
        341393,2 Fix ignored submodules if a submodule does not have a dependency.yaml 6.1 qt/qt5 Status: MERGED +2 0
        341460,2 Fix ignored submodules if a submodule does not have a dependency.yaml dev qt/qt5 Status: MERGED +2 0

        Activity

          People

            kkohne Kai Köhne
            kkohne Kai Köhne
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes