Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
6.0.3, 6.1.0 Beta2
-
None
-
-
bcbbbdb2d640c059c19e9337c7418b83b1b7e4ea (qt/qtbase/dev) dc9b55d6b232868a86471a6c0fcc17a82b0c7609 (qt/qtbase/6.0) f4292c10a3b0128a0bd41246a3084ffe814dd2c6 (qt/qtbase/6.1)
Description
The QRegularExpression rx variable inside the implementation of QSortFilterProxyModel::setFilterRegularExpression(const QString &) is unused. QRegularExpression::setPattern() leaves the pattern options unchanged. The intent of the current code seems to be: reset all pattern options except for QRegularExpression::CaseInsensitiveOption to defaults. This can be achieved by removing the unused variable rx and adding the following line:
d->filter_data.setPatternOptions(d->filter_data.patternOptions() & QRegularExpression::CaseInsensitiveOption);
Before Qt 5.15.2 this member function preserved none of the pattern options. With https://codereview.qt-project.org/c/qt/qtbase/+/310989 included in Qt 5.15.2, only QRegularExpression::CaseInsensitiveOption is preserved.
Attachments
Issue Links
- relates to
-
QTBUG-83313 Setting CaseSensitivity in QSortFilterProxymodel for QRegularExpression doesn't work
- Closed
For Gerrit Dashboard: QTBUG-92260 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
341665,7 | Fix case sensitivity handling QSFPM | dev | qt/qtbase | Status: MERGED | +2 | 0 |
344731,2 | Fix case sensitivity handling QSFPM | 6.0 | qt/qtbase | Status: MERGED | +2 | 0 |
344732,2 | Fix case sensitivity handling QSFPM | 6.1 | qt/qtbase | Status: MERGED | +2 | 0 |