Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-9254

qt3support/network/q3socketdevice_win.cpp big include order mistake

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 4.7.0
    • 4.6.2, 4.6.3, 4.7.0, 4.7.1, 5.0.0, Some future release
    • None
    • None
    • windows with cmd.exe and mingw(-w64) gcc
    • 5d65e3c264332262fb09b8fe6f08d284c088a61d

    Description

      In the abovementioned file, there is a false include with mingw(-w64):

      line 50: includes windows.h, which includes winsock.h
      line 54-55: includes winsock2.h AFTER winsock.h when using gcc. This results in many double functions and is not allowed as per MSDN.

      Proposed resolution: move line 50 to line 88, so that winsock2.h will not be included after windows.h

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            vfm Thierry Bastian (closed Nokia identity) (Inactive)
            rubenvb Ruben Van Boxem
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes