-
Bug
-
Resolution: Done
-
P2: Important
-
6.1.0, 6.1.1
-
None
-
Windows
-
523ee5577a3fb1801dc765511c2c76753c10a72e (qt/qtbase/dev) f17d8982d7ca774a45b37f78a3d4cc3ce1042217 (qt/qtbase/6.2) a8dc7b7a1adc229f010151a789fb959d48a02ee7 (qt/qtbase/6.1)
Toolchain says;
set(CMAKE_CXX_FLAGS " /nologo /DWIN32 /D_WINDOWS /W3 ${CHARSET_FLAG} /GR /EHsc /MP ${VCPKG_CXX_FLAGS}" CACHE STRING "")
Qt does:
/nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR/MP /D_DEBUG /MTd /Z7 /RTC1 -MTd /W3
with
cl : Command line warning D9002 : ignoring unknown option '/G/' cl : Command line warning D9002 : ignoring unknown option '/GM' cl : Command line warning D9002 : ignoring unknown option '/GP'
Reason : qtbase/cmake/QtFLagHandlingHelpers.cmake
qt_internal_remove_compiler_flags("(^| )/EH[scra-]*( |$)" LANGUAGES CXX CONFIGS ${configs} IN_CACHE REGEX)
goes into
qt_internal_remove_flags_impl
which does:
string(${replace_type} "${flag_value}" "" mod_flags "${mod_flags}")
which needs to be
string(${replace_type} "${flag_value}" " " mod_flags "${mod_flags}")
to be correct!
| For Gerrit Dashboard: QTBUG-94400 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 353779,4 | Replace flags with spaces when removing them | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 353923,2 | Replace flags with spaces when removing them | 6.2 | qt/qtbase | Status: MERGED | +2 | 0 |
| 353924,2 | Replace flags with spaces when removing them | 6.1 | qt/qtbase | Status: MERGED | +2 | 0 |