Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-94827

[PoC patch] qt3d: render: crash / data race in OffscreenSurfaceHelper

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reported
    • Priority: P1: Critical
    • Resolution: Unresolved
    • Affects Version/s: 5.14.0 RC2, 5.15.0 RC2
    • Fix Version/s: None
    • Component/s: Qt3D
    • Labels:
      None
    • Platform/s:
      Linux/X11, Windows

      Description

      OffscreenSurfaceHelper accesses AbstractRenderer which (I believe) lives in a rendering thread. Surface creation is done via a queued slot connection but there is no synchronisation to whether the renderer is still valid. It seems safer to queue the parameters instead.

      The proof-of-concept patch is attached. I've verified it fixes the crash for us. It's not particularly formatted according to guidelines (I can do it if the patch approach is approved as-is).

      Unfortunately I don't have a minimal example (it only happens under a heavy load, only on certain machines, and only when there are plenty of other business logic threads).

       

        Attachments

        1. osh-race-stackstrace.png
          10 kB
          Ievgen Liubymkin
        2. osh-race-v2.patch
          6 kB
          Ievgen Liubymkin
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            seanharmer Sean Harmer
            Reporter:
            jive Ievgen Liubymkin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes