Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-95005

Typo in QOpenGLPaintDevice::dotsPerMeterY

    XMLWordPrintable

    Details

    • Platform/s:
      All
    • Commits:
      85831bcfe6ce36740c524d641ada79c65aadd89b (qt/qtbase/dev) 1e81517613faf39adeb1e089be36542164bc90f6 (qt/qtbase/6.2) 0db58b62ee57fbe56f2f11dcfc5461d83de7dbda (qt/qtbase/5.12) 17ff3b5b9a61f2049488b21c4550eace22a6f08e (qt/tqtc-qtbase/5.15)

      Description

      `QOpenGLPaintDevice::setDotsPerMeterY` does not set the Y dpm correctly. Looking at the source, it seems that the wrong variable is being assigned (https://code.qt.io/cgit/qt/qtbase.git/tree/src/opengl/qopenglpaintdevice.cpp#n334):

      
      void QOpenGLPaintDevice::setDotsPerMeterY(qreal dpmy)
      
      { 
           d_ptr->dpmx = dpmy;
      }
      
      

      It should probably be `d_ptr->dpmy`. I think it might affect the layout and rendering of text documents and possibly other stuff on `QOpenGLPaintDevice`.
      This affects Qt 5.12, but the latest revision still contains this code.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            liaqi Liang Qi
            Reporter:
            ableron AA AAAAAA
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews