Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-94581 Review and Document new Qt 6.2 CMake API
  3. QTBUG-95150

Restrict qt_target_qml_sources usage to real QML modules only

XMLWordPrintable

    • 4b7d03190559e3d04383e5702b720e3075e11fa3 (qt/qtdeclarative/dev) 7fffac536ce117ca5ebc5ca9b505744927c385d8 (qt/qtdeclarative/6.2)

      Context
      https://git.qt.io/alcroito/qt6-cmake-api-review/-/commit/14b4999bc857f5402a3577fe334ebfb3602ad0c2#f3ff9c1b48af14adf093e2af0c5cf2849829bb6d_186_248

      We should only allow calling qt_target_qml_sources for real qml modules, aka targets that had qt_add_qml_module called on them.

      We can relax this restriction in future Qt versions if the need arises.

      This might imply documenting that in certain cases qml files should be added with qt_add_resources instead, but we need to very careful about advertising that if we do at all.

        For Gerrit Dashboard: QTBUG-95150
        # Subject Branch Project Status CR V
        362553,2 Enforce target given to qt6_target_qml_sources() must be a QML module dev qt/qtdeclarative Status: MERGED +2 0
        362968,2 Enforce target given to qt6_target_qml_sources() must be a QML module 6.2 qt/qtdeclarative Status: MERGED +2 0

            crscott Craig Scott
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes