Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-94581 Review and Document new Qt 6.2 CMake API
  3. QTBUG-95174

Adjust new options of qt6_add_shaders and rename qt6_internal_add_shaders as internal

    XMLWordPrintable

Details

    Description

      Context
      https://git.qt.io/alcroito/qt6-cmake-api-review/-/commit/5313c017d09c51d9034dd62b33f968b9cd54363c#179fb5213a114272e340c63285f9fb35ba530ab8_246_278
      https://git.qt.io/alcroito/qt6-cmake-api-review/-/commit/5313c017d09c51d9034dd62b33f968b9cd54363c#179fb5213a114272e340c63285f9fb35ba530ab8_246_278

      Document OUTPUTS and SILENT options.
      Consider renaming `SILENT` option to `QUIET`, to be more in line with CMake naming.

      Rename qt6_add_shaders_impl to _qt_internal_add_shaders_impl because it's not meant to be public.

      Rename qt6_internal_add_shaders to _qt_internal_add_shaders for the same reason.

      Remove qt_internal_add_shaders.

      Attachments

        For Gerrit Dashboard: QTBUG-95174
        # Subject Branch Project Status CR V
        362285,3 CMake: Accept QUIET as a synonym for SILENT dev qt/qtshadertools Status: MERGED +2 0
        362289,6 CMake: Mark internal helpers as _qt_internal dev qt/qtshadertools Status: MERGED +2 0
        362810,2 CMake: Accept QUIET as a synonym for SILENT 6.2 qt/qtshadertools Status: MERGED +2 0
        362811,2 CMake: Mark internal helpers as _qt_internal 6.2 qt/qtshadertools Status: MERGED +2 0

        Activity

          People

            lagocs Laszlo Agocs
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes