Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-94581 Review and Document new Qt 6.2 CMake API
  3. QTBUG-95207

Show error if qt_add_qml_module is called twice in the same directory scope

    XMLWordPrintable

Details

    • 0cca1f27fe32fdf62850b2037509ff1d516a6309 (qt/tqtc-qtdeclarative/6.2) 2a374f15a8b40da008b3fa6d868359e49c2bae06 (qt/tqtc-qtdeclarative/dev)

    Description

      Context: https://codereview.qt-project.org/c/qt/qtdeclarative/+/359918/6#message-7f1fe70b81848585757ac126b17c039c4fd7dd83

      One might try to add 2 qml modules in the same directory scope like here
      https://codereview.qt-project.org/c/qt/qtdeclarative/+/359918/5/tests/auto/qml/qmlbasicapp/CMakeLists.txt

      This would silently override the qmldir.

      We should FATAL_ERROR if qt_add_qml_module is called twice within the same directory scope.

      Perhaps also if qt_add_qml_plugin is called twice in the same scope, it that even make sense.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-131296 qmlls fails to parse some QML modules and C++ types when there is more than one QML module in a directory

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-103594 qt_add_qml_module default value for OUTPUT_DIRECTORY creates conflicts

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              crscott Craig Scott
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes