Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-95390

Only test controls that each style implements

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Quick: Controls 2
    • Labels:
      None
    • Technical Risk:
      Normal

      Description

      Currently (besides the native styles, which aren't tested) we run a bunch of tests in tests/auto/quickcontrols2/controls unnecessarily. Using this script, those files are:

      Exclusions for fusion:
      
      list(FILTER test_data EXCLUDE REGEX "(\
      .*tst_abstractbutton.qml|\
      .*tst_actiongroup.qml|\
      .*tst_action.qml|\
      .*tst_buttongroup.qml|\
      .*tst_container.qml|\
      .*tst_control.qml|\
      .*tst_selectionrectangle.qml|\
      .*tst_stackview.qml|\
      .*tst_swipeview.qml\
      )")
      
      Exclusions for imagine:
      
      list(FILTER test_data EXCLUDE REGEX "(\
      .*tst_abstractbutton.qml|\
      .*tst_actiongroup.qml|\
      .*tst_action.qml|\
      .*tst_buttongroup.qml|\
      .*tst_container.qml|\
      .*tst_control.qml|\
      .*tst_menubaritem.qml|\
      .*tst_menubar.qml|\
      .*tst_selectionrectangle.qml\
      )")
      
      Exclusions for material:
      
      list(FILTER test_data EXCLUDE REGEX "(\
      .*tst_abstractbutton.qml|\
      .*tst_actiongroup.qml|\
      .*tst_action.qml|\
      .*tst_buttongroup.qml|\
      .*tst_container.qml|\
      .*tst_control.qml|\
      .*tst_selectionrectangle.qml\
      )")
      
      Exclusions for macos:
      
      list(FILTER test_data EXCLUDE REGEX "(\
      .*tst_abstractbutton.qml|\
      .*tst_actiongroup.qml|\
      .*tst_action.qml|\
      .*tst_applicationwindow.qml|\
      .*tst_busyindicator.qml|\
      .*tst_buttongroup.qml|\
      .*tst_checkdelegate.qml|\
      .*tst_container.qml|\
      .*tst_control.qml|\
      .*tst_delaybutton.qml|\
      .*tst_dialogbuttonbox.qml|\
      .*tst_dialog.qml|\
      .*tst_drawer.qml|\
      .*tst_horizontalheaderview.qml|\
      .*tst_itemdelegate.qml|\
      .*tst_label.qml|\
      .*tst_menubaritem.qml|\
      .*tst_menubar.qml|\
      .*tst_menuitem.qml|\
      .*tst_menu.qml|\
      .*tst_menuseparator.qml|\
      .*tst_pageindicator.qml|\
      .*tst_page.qml|\
      .*tst_pane.qml|\
      .*tst_popup.qml|\
      .*tst_radiodelegate.qml|\
      .*tst_rangeslider.qml|\
      .*tst_roundbutton.qml|\
      .*tst_scrollindicator.qml|\
      .*tst_selectionrectangle.qml|\
      .*tst_splitview.qml|\
      .*tst_stackview.qml|\
      .*tst_swipedelegate.qml|\
      .*tst_swipeview.qml|\
      .*tst_switchdelegate.qml|\
      .*tst_switch.qml|\
      .*tst_tabbar.qml|\
      .*tst_tabbutton.qml|\
      .*tst_toolbar.qml|\
      .*tst_toolbutton.qml|\
      .*tst_toolseparator.qml|\
      .*tst_tooltip.qml|\
      .*tst_tumbler.qml|\
      .*tst_verticalheaderview.qml\
      )")
      
      Exclusions for universal:
      
      list(FILTER test_data EXCLUDE REGEX "(\
      .*tst_abstractbutton.qml|\
      .*tst_actiongroup.qml|\
      .*tst_action.qml|\
      .*tst_buttongroup.qml|\
      .*tst_container.qml|\
      .*tst_control.qml|\
      .*tst_selectionrectangle.qml|\
      .*tst_swipeview.qml\
      )")
      
      Exclusions for windows:
      
      list(FILTER test_data EXCLUDE REGEX "(\
      .*tst_abstractbutton.qml|\
      .*tst_actiongroup.qml|\
      .*tst_action.qml|\
      .*tst_applicationwindow.qml|\
      .*tst_busyindicator.qml|\
      .*tst_buttongroup.qml|\
      .*tst_checkdelegate.qml|\
      .*tst_container.qml|\
      .*tst_control.qml|\
      .*tst_delaybutton.qml|\
      .*tst_dialogbuttonbox.qml|\
      .*tst_dialog.qml|\
      .*tst_dial.qml|\
      .*tst_drawer.qml|\
      .*tst_horizontalheaderview.qml|\
      .*tst_itemdelegate.qml|\
      .*tst_label.qml|\
      .*tst_menubaritem.qml|\
      .*tst_menubar.qml|\
      .*tst_menuitem.qml|\
      .*tst_menu.qml|\
      .*tst_menuseparator.qml|\
      .*tst_pageindicator.qml|\
      .*tst_page.qml|\
      .*tst_pane.qml|\
      .*tst_popup.qml|\
      .*tst_radiodelegate.qml|\
      .*tst_rangeslider.qml|\
      .*tst_roundbutton.qml|\
      .*tst_scrollindicator.qml|\
      .*tst_selectionrectangle.qml|\
      .*tst_splitview.qml|\
      .*tst_stackview.qml|\
      .*tst_swipedelegate.qml|\
      .*tst_swipeview.qml|\
      .*tst_switchdelegate.qml|\
      .*tst_switch.qml|\
      .*tst_tabbar.qml|\
      .*tst_tabbutton.qml|\
      .*tst_toolbar.qml|\
      .*tst_toolbutton.qml|\
      .*tst_toolseparator.qml|\
      .*tst_tooltip.qml|\
      .*tst_tumbler.qml|\
      .*tst_verticalheaderview.qml\
      )")
      

      Work was started on this for the change that will add the Windows style to tests/auto/quickcontrols2/controls:

      https://codereview.qt-project.org/c/qt/qtquickcontrols2/+/356159/2/

      However, I ran into some issues:

      https://bugreports.qt.io/browse/QTBUG-94961?focusedCommentId=577067&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-577067

      Once these are fixed, we should exclude all unnecessary QML files from these tests.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              qt.team.quick.subscriptions Qt Quick and Widgets Team
              Reporter:
              mitch_curtis Mitch Curtis
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes