Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-95590

Rewrite cmake-gn intergration

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • None
    • 6.2
    • WebEngine
    • None
    • All

    Description

      Currently cmake-gn integration sucks big time and makes top level builds impossible to run smoothly. 

      Go back to the drawing board and rewrite it so:

      1. gn runs during build time (we can use generator expressions)
      2. gn just produces static lib (cross platform wise)  and this is IMPORTED lib for cmake -> no more need for passing object and archives to cmake. Note this requires rewriting final target in gn and adding platform specific commands and it was investigated long time ago with outcome that msvc 2015 was not fit enough to do the job, so retry with more recent tooolchains.
      3. Remove all the unnecessary external projects and insane dummy targets.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. COIN-699 add ulimit for linux nodes

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-95152 A QtWebEngine build fails on dev on M1 MacBook

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-95158 Insource/Namespace/Shadow build fails.

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94349 cmake cannot find Qt6Targets.cmake and Qt6VersionlessTargets.cmake when configuring prefix build

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94709 6.2.0 Qt src package, webengine not compiling

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94922 base/logging_buildflags.h may not be generated in time with top-level build

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94997 qtwebengine not respecting CMAKE_INSTALL_PREFIX

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94804 QtWebEngine install doesn't honor DESTDIR

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-95051 qtwebengine not forwarding CMAKE_BUILD_TYPE correctly.

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTBUG-95590
          # Subject Branch Project Status CR V
          361701,42 Rewrite gn-cmake integration dev qt/qtwebengine Status: MERGED +2 0
          365036,9 Add rsp target writer 90-based qt/qtwebengine-chromium Status: MERGED +2 0
          365210,10 Use rsp files directly from gn dev qt/qtwebengine Status: MERGED +2 0
          365582,10 Add 'amazing' windows linker workaround for rsp files dev qt/qtwebengine Status: MERGED +2 0
          366354,29 Fix issue of not working dictionary conversion dev qt/qtwebengine Status: MERGED +2 0
          366858,20 Add workaround for not working linking with bfd linker dev qt/qtwebengine Status: MERGED +2 0
          367117,3 Remove obsolete cmake link writer 90-based qt/qtwebengine-chromium Status: MERGED +2 0
          367441,3 Use rsp files directly from gn 6.2 qt/qtwebengine Status: MERGED +2 0
          367442,3 Add 'amazing' windows linker workaround for rsp files 6.2 qt/qtwebengine Status: MERGED +2 0
          367444,4 Add workaround for not working linking with bfd linker 6.2 qt/qtwebengine Status: MERGED +2 0
          367445,4 Fix issue of not working dictionary conversion 6.2 qt/qtwebengine Status: MERGED +2 0
          367446,3 Rewrite gn-cmake integration 6.2 qt/qtwebengine Status: MERGED +2 0
          367541,6 Fix target name collision for top level build dev qt/qtwebengine Status: MERGED +2 0
          367588,5 Use generator expression to get moc path dev qt/qtwebengine Status: MERGED +2 0
          367657,6 Simplify test examples target includes dev qt/qtwebengine Status: MERGED +2 0
          367658,5 Adjust install and copy path for locales and resources dev qt/qtwebengine Status: MERGED +2 0
          367855,2 Use generator expression to get moc path 6.2 qt/qtwebengine Status: MERGED +2 0
          367856,2 Adjust install and copy path for locales and resources 6.2 qt/qtwebengine Status: MERGED +2 0
          367857,2 Simplify test examples target includes 6.2 qt/qtwebengine Status: MERGED +2 0
          367858,2 Fix target name collision for top level build 6.2 qt/qtwebengine Status: MERGED +2 0

          Activity

            People

              michal Michal Klocek
              michal Michal Klocek
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: