Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-95832

QtRemoteObjects CMake API is using the internal qt_manual_moc API

    XMLWordPrintable

Details

    • 7e58270087f705ab1b5b499c0849baac6a2f56ea (qt/qtremoteobjects/6.2.0) d4bdbfea209a97b7e6331f744e5b50359241540b (qt/qtremoteobjects/6.2) debee63fa7f9a1dc408a82f20f7a36f74c53e301 (qt/qtremoteobjects/dev) b47f4ef3a3 (qt/qtremoteobjects/6.2.3)

    Description

      Discovered as part of review at https://codereview.qt-project.org/c/qt/qtremoteobjects/+/364791/4#message-ad5271abda222f469147a85adc84e6004bdfd25a

      Both _qt_internal_add_repc_files and qt6_reps_from_headers use qt_manual_moc which is private CMake api defined in qtbase/cmake/QtAutogenHelpers.cmake

      It's not clear if the API works at all.

      It should either be replaced by using AUTOMOC or _qt_internal_create_moc_command / qt6_generate_moc.

      One particular bump in doing in that is that the RemoteObjects API seems to rely on the OUTPUT_MOC_JSON_FILES parameter of qt_manual_moc, which is not exposed by any of the public equivalents afaik.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. QTBUG-95833 Port and enable qtremoteobjects CMake auto tests

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-125329 Grpc generators: fix Policy CMP0071

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-95832
          # Subject Branch Project Status CR V
          371550,7 CMake: Add option in qt6_wrap_cpp to output a metatypes json file 6.2.0 qt/qtbase Status: MERGED +2 0
          371551,5 CMake: Use new __QT_INTERNAL_OUTPUT_MOC_JSON_FILES option in API dev qt/qtremoteobjects Status: MERGED +2 0
          371552,3 CMake: Use new __QT_INTERNAL_OUTPUT_MOC_JSON_FILES option in API 6.2.0 qt/qtremoteobjects Status: MERGED +2 0
          371633,2 CMake: Add option in qt6_wrap_cpp to output a metatypes json file 6.2 qt/qtbase Status: MERGED +2 0
          371634,2 CMake: Add option in qt6_wrap_cpp to output a metatypes json file dev qt/qtbase Status: MERGED +2 0
          371960,2 CMake: Use new __QT_INTERNAL_OUTPUT_MOC_JSON_FILES option in API 6.2 qt/qtremoteobjects Status: MERGED +2 0
          372063,5 CMake: Manually run moc on generated rep_$name_$type headers dev qt/qtremoteobjects Status: MERGED +2 0
          372114,10 CMake: Warn if cmake_minimum_required has an unsupported low version dev qt/qtbase Status: MERGED +2 0
          372476,2 CMake: Manually run moc on generated rep_$name_$type headers 6.2 qt/qtremoteobjects Status: MERGED +2 0
          372521,2 CMake: Manually run moc on generated rep_$name_$type headers 6.2.0 qt/qtremoteobjects Status: MERGED +2 0
          374611,2 CMake: Warn if cmake_minimum_required has an unsupported low version 6.2 qt/qtbase Status: MERGED +2 0
          374801,2 Revert "CMake: Warn if cmake_minimum_required has an unsupported low version" 6.2 qt/qtbase Status: MERGED +2 0
          374918,2 Revert "CMake: Warn if cmake_minimum_required has an unsupported low version" dev qt/qtbase Status: MERGED +2 0

          Activity