Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-96737

Allow warning about customisation of native styles with qmllint

    XMLWordPrintable

Details

    Description

      This is required for QTBUG-96733. The idea is that modification of certain properties of the types in https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quickcontrols2/macos and https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quickcontrols2/windows should result in a warning by qmllint. For example, something like:

      Button {
    contentItem: Item { /* ... */ } // warning: native styles (macOS and Windows) cannot be customised: see https://doc-snapshots.qt.io/qt6-dev/qtquickcontrols2-customize.html#customization-reference for more information.
}

      Button {
    padding: 5 // warning: native styles (macOS and Windows) cannot be customised: see https://doc-snapshots.qt.io/qt6-dev/qtquickcontrols2-customize.html#customization-reference for more information.
}

      We would like to have this on by default if possible, as our current approach of relying on documentation is not enough.

      Attachments

        Issue Links

          is required for

          Task - A task that needs to be done. QTBUG-96733 Prevent users from customising native styles

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Reported
          For Gerrit Dashboard: QTBUG-96737
          # Subject Branch Project Status CR V
          405855,10 qmllint/Quick: Warn about customizing native QtQuick.Controls styles dev qt/qtdeclarative Status: MERGED +2 0
          406860,8 QmlLintQuickPlugin: Warn about invalid anchors combinations dev qt/qtdeclarative Status: MERGED +2 0

          Activity

            People

              qtqmlteam Qt Qml Team User
              mitch_curtis Mitch Curtis
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes