Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-97094

Wayland modifiers map decoding has flawed logic

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.12, 5.15, 6.2
    • Fix Version/s: 5.12.12, 5.15.8, 6.3.0 Alpha
    • Component/s: QPA: Wayland
    • Labels:
      None
    • Platform/s:
      Linux/Wayland
    • Commits:
      baa7ef511bf40280448e5f0e721ddd6da3301f3b (qt/qtwayland/dev) 190646bcf0ae20174f32a240a81c9830dedd3c9b (qt/qtwayland/5.12) 60f908ba70cd52fd980887244b9a9fc9f9c34b4b (qt/qtwayland/6.2) 1887f6b4b6e689dcb1c60f1e78fffac31e5ce4a6 (qt/tqtc-qtwayland/5.15)

      Description

      Logic for decoding the modifiers map for the text input Wayland protocol is flawed, and results in incorrect values being used. This is due to the attempt at using bit shifting as the conditional of the for loop, which modifies the variable in question before evaluating the truthiness. Attached patch fixes this to check the flags correctly.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            qt.team.graphics.and.multimedia Qt Graphics Team
            Reporter:
            dobey Rodney Dawes
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: