Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-98130

QtQuick and controls examples use qt_add_resources to add QML files

    XMLWordPrintable

Details

    Description

      They should use qt_add_qml_module (list generated with git grep qt6_add_resources – examples | cat):

      • examples/quick/embeddedinwidgets/CMakeLists.txt:qt6_add_resources(embeddedinwidgets "embeddedinwidgets"
      • examples/quick/keyinteraction/CMakeLists.txt:qt6_add_resources(keyinteraction "keyinteraction"
      • examples/quick/models/abstractitemmodel/CMakeLists.txt:qt6_add_resources(abstractitemmodel "abstractitemmodel"
      • examples/quick/models/objectlistmodel/CMakeLists.txt:qt6_add_resources(objectlistmodel "objectlistmodel"
      • examples/quick/models/stringlistmodel/CMakeLists.txt:qt6_add_resources(stringlistmodel "stringlistmodel"
      • examples/quick/mousearea/CMakeLists.txt:qt6_add_resources(mousearea "mousearea"
      • examples/quick/particles/affectors/CMakeLists.txt:qt6_add_resources(affectors "affectors"
      • examples/quick/particles/affectors/CMakeLists.txt:qt6_add_resources(affectors "images"
      • examples/quick/particles/affectors/CMakeLists.txt:qt6_add_resources(affectors "shared"
      • examples/quick/particles/emitters/CMakeLists.txt:qt6_add_resources(emitters "emitters"
      • examples/quick/particles/emitters/CMakeLists.txt:qt6_add_resources(emitters "images"
      • examples/quick/particles/emitters/CMakeLists.txt:qt6_add_resources(emitters "shared"
      • examples/quick/particles/imageparticle/CMakeLists.txt:qt6_add_resources(imageparticle "imageparticle"
      • examples/quick/particles/imageparticle/CMakeLists.txt:qt6_add_resources(imageparticle "images"
      • examples/quick/particles/imageparticle/CMakeLists.txt:qt6_add_resources(imageparticle "shared"
      • examples/quick/particles/itemparticle/CMakeLists.txt:qt6_add_resources(itemparticle "images"
      • examples/quick/particles/itemparticle/CMakeLists.txt:qt6_add_resources(itemparticle "shared"
      • examples/quick/particles/itemparticle/CMakeLists.txt:qt6_add_resources(itemparticle "qmake_immediate"
      • examples/quick/particles/system/CMakeLists.txt:qt6_add_resources(system "system"
      • examples/quick/particles/system/CMakeLists.txt:qt6_add_resources(system "images"
      • examples/quick/particles/system/CMakeLists.txt:qt6_add_resources(system "shared"
      • examples/quick/rendercontrol/rendercontrol_d3d11/CMakeLists.txt:qt6_add_resources(rendercontrol_d3d11 "rendercontrol"
      • examples/quick/rendercontrol/rendercontrol_opengl/CMakeLists.txt:qt6_add_resources(rendercontrol_opengl "rendercontrol"
      • examples/quickcontrols2/chattutorial/chapter1-settingup/CMakeLists.txt:qt6_add_resources(chapter1-settingup "qml" https://codereview.qt-project.org/c/qt/qtdeclarative/+/380363
      • examples/quickcontrols2/chattutorial/chapter2-lists/CMakeLists.txt:qt6_add_resources(chapter2-lists "qml"
      • examples/quickcontrols2/chattutorial/chapter2-lists/CMakeLists.txt:qt6_add_resources(chapter2-lists "shared"
      • examples/quickcontrols2/chattutorial/chapter3-navigation/CMakeLists.txt:qt6_add_resources(chapter3-navigation "qml"
      • examples/quickcontrols2/chattutorial/chapter3-navigation/CMakeLists.txt:qt6_add_resources(chapter3-navigation "shared"
      • examples/quickcontrols2/chattutorial/chapter4-models/CMakeLists.txt:qt6_add_resources(chapter4-models "qml"
      • examples/quickcontrols2/chattutorial/chapter4-models/CMakeLists.txt:qt6_add_resources(chapter4-models "shared"
      • examples/quickcontrols2/chattutorial/chapter5-styling/CMakeLists.txt:qt6_add_resources(chapter5-styling "qml"
      • examples/quickcontrols2/chattutorial/chapter5-styling/CMakeLists.txt:qt6_add_resources(chapter5-styling "shared"
      • examples/quickcontrols2/contactlist/CMakeLists.txt:qt6_add_resources(contactlist "qmake_immediate"
      • examples/quickcontrols2/flatstyle/CMakeLists.txt:qt6_add_resources(flatstyle "qmake_immediate"
      • examples/quickcontrols2/gallery/CMakeLists.txt:qt6_add_resources(gallery_controls2 "qmake_immediate" # special case
      • examples/quickcontrols2/imagine/automotive/CMakeLists.txt:qt6_add_resources(automotive "icons"
      • examples/quickcontrols2/imagine/automotive/CMakeLists.txt:qt6_add_resources(automotive "imagine-assets"
      • examples/quickcontrols2/imagine/automotive/CMakeLists.txt:qt6_add_resources(automotive "qml"
      • examples/quickcontrols2/imagine/automotive/CMakeLists.txt:qt6_add_resources(automotive "qmake_immediate"
      • examples/quickcontrols2/imagine/musicplayer/CMakeLists.txt:qt6_add_resources(musicplayer "icons"
      • examples/quickcontrols2/imagine/musicplayer/CMakeLists.txt:qt6_add_resources(musicplayer "imagine-assets"
      • examples/quickcontrols2/imagine/musicplayer/CMakeLists.txt:qt6_add_resources(musicplayer "qmake_immediate"
      • examples/quickcontrols2/sidepanel/CMakeLists.txt:qt6_add_resources(sidepanel "qmake_immediate"
      • examples/quickcontrols2/swipetoremove/CMakeLists.txt:qt6_add_resources(swipetoremove "qmake_immediate"
      • examples/quickcontrols2/texteditor/CMakeLists.txt:qt6_add_resources(texteditor "texteditor"
      • examples/quickcontrols2/wearable/CMakeLists.txt:qt6_add_resources(wearable "wearable"

      Attachments

        Issue Links

          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-100100 Demos should use `qt6_add_qml_module` instead of `qt6_add_resources`

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-98130
          # Subject Branch Project Status CR V
          380363,18 Fix CMakeLists.txts of chattutorial dev qt/qtdeclarative Status: MERGED +2 0
          380386,4 Embeddedinwidgets example: use qt_add_qml_module() dev qt/qtdeclarative Status: MERGED +2 0
          380393,5 Keyinteraction example: use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          380394,4 MouseArea example: use qt_add_qml_module() and update a signal handler dev qt/qtdeclarative Status: MERGED +2 0
          380585,3 Fix CMakeLists.txts of chattutorial 6.2 qt/qtdeclarative Status: MERGED +2 0
          380618,12 Particle examples: use new cmake api dev qt/qtdeclarative Status: MERGED +2 0
          380622,1 Fix qtquickcontrols2.conf files dev qt/qtdeclarative Status: ABANDONED 0 0
          380980,3 Particle examples: use new cmake api 6.2 qt/qtdeclarative Status: MERGED +2 0
          380984,4 Keyinteraction example: use qt_add_qml_module() in CMakeLists.txt 6.2 qt/qtdeclarative Status: MERGED +2 0
          380985,2 MouseArea example: use qt_add_qml_module() and update a signal handler 6.2 qt/qtdeclarative Status: MERGED +2 0
          380986,2 Embeddedinwidgets example: use qt_add_qml_module() 6.2 qt/qtdeclarative Status: MERGED +2 0
          381024,3 Rendercontrol example: use new cmake api dev qt/qtdeclarative Status: MERGED +2 0
          381109,2 Model examples: use new cmake api dev qt/qtdeclarative Status: MERGED +2 0
          381193,2 Model examples: use new cmake api 6.2 qt/qtdeclarative Status: MERGED +2 0
          381414,2 Rendercontrol example: use new cmake api 6.2 qt/qtdeclarative Status: MERGED +2 0
          398152,4 SwipeToRemove example: use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434337,3 TextEditor example: use qt_add_qml_module in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434349,3 SidePanel example: use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434364,2 Contactlist example: use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434369,2 Gallery example: Use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434370,2 Flatstyle example: use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434384,2 Automotive example: Use qt_add_qml_module() dev qt/qtdeclarative Status: MERGED +2 0
          434385,2 Musicplayer example: use qt_add_qml_module() in CMakeLists.txt dev qt/qtdeclarative Status: MERGED +2 0
          434797,2 Musicplayer example: use qt_add_qml_module() in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434798,2 Gallery example: Use qt_add_qml_module() in CMakeLists.txt 6.3 qt/qtdeclarative Status: MERGED +2 0
          434799,2 SwipeToRemove example: use qt_add_qml_module() in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434800,2 Contactlist example: use qt_add_qml_module() in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434801,3 SidePanel example: use qt_add_qml_module() in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434802,3 Flatstyle example: use qt_add_qml_module() in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434803,3 Automotive example: Use qt_add_qml_module() 6.4 qt/qtdeclarative Status: MERGED +2 0
          434804,2 TextEditor example: use qt_add_qml_module in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434805,2 Gallery example: Use qt_add_qml_module() in CMakeLists.txt 6.4 qt/qtdeclarative Status: MERGED +2 0
          434806,1 Musicplayer example: use qt_add_qml_module() in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434807,1 SwipeToRemove example: use qt_add_qml_module() in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434808,2 Contactlist example: use qt_add_qml_module() in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434809,2 SidePanel example: use qt_add_qml_module() in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434810,2 Flatstyle example: use qt_add_qml_module() in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434811,1 Gallery example: Use qt_add_qml_module() in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434812,1 Automotive example: Use qt_add_qml_module() tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0
          434813,1 TextEditor example: use qt_add_qml_module in CMakeLists.txt tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: ABANDONED 0 0

          Activity

            People

              qt.team.quick.subscriptions Qt Quick and Widgets Team
              ulherman Ulf Hermann
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes