Loading...

XML

Word

Printable

Type: Task
Resolution: Unresolved
Priority: P2: Important
Fix Version/s: None
Affects Version/s: None
Component/s: Quick: Core Declarative QML
Labels:
- Low_Hanging_Fruit_Contributions_Welcome

Commits:
1465d428e (6.5), 44bf048c9 (dev), eaafda38d (6.6), 131c976b8 (6.5), 80b7d0cfb (dev), 264fe7d68 (6.6), 821aa3dcc (tqtc/lts-6.5), 71b62a4e5 (dev), 0625712e7 (6.6), a22a8ed91 (tqtc/lts-6.5), c2fa37c42 (dev), 27efcaa34 (dev), 60e5d8592 (dev), cfcce18bd (dev)

Now that https://codereview.qt-project.org/c/qt/qtbase/+/375915 is merged, we can start preventing new warnings from creeping into qtdeclarative.

My proposal is to do this in tests that aren't based on QQmlDataTest:

void tst_foo::init()
{
    QTest::failOnWarning();
}

and this in the constructor of those that are:

// ...
 : QQmlDataTest(QT_QMLTEST_DATADIR, FailOnWarningsPolicy::FailOnWarnings)
{
}

This would make every QQmlDataTest-based test function in qtdeclarative fail if a qWarning is encountered. It would require a bit of work up front: a few tests would probably require a bunch of QTest::ignoreMessages, and ~~QTBUG-98439~~ would need to be fixed first.

In addition, we should add a bool failOnWarnings to TestCase, defaulting it to the value of QT_QUICK_TEST_FAIL_ON_WARNINGS if it is set, otherwise false. This will allow us to enable it for all QML tests in the least disruptive way.

This won't cover every test, but it's a good start.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List

qtdeclarative-qwarnings-ubuntu.txt
278 kB
16 Dec '21 12:55

depends on

QTBUG-140242 QSGThreadedRenderLoop cleanup with QQuickWindow swapchain still alive, this should not happen.

Reported

QTBUG-99231 "Could not set initial property horizontalAlignment" when trying to set resettable property

Reported

QTBUG-135009 tst_Snippets::verify(qtquickcontrols-spinbox-custom): "There are still \"2\" items in the process of being created at engine destruction."

Reported

QTBUG-98439 "Binding on contentItem is not deferred as requested by the DeferredPropertyNames class info because it constitutes a group property" when instantiating ScrollBar

Closed

QTBUG-119572 [Tests] Warnings in tst_controls::Imagine::RangeSlider::test_nullHandles()

Closed

QTBUG-119573 [Tests] Warning in tst_controls::Imagine::Popup::test_popupOverlayCenterIn()

Closed

QTBUG-119633 [Tests] Warnings in qtdeclarative/tests/auto/quickcontrols/controls/data/tst_slider.qml

Closed

QTBUG-119644 [Tests] Warnings in qtdeclarative/tests/auto/quickcontrols/controls/data/tst_combobox.qml

Closed

QTBUG-119645 [Tests] Warnings in qtdeclarative/tests/auto/quickcontrols/controls/data/tst_textarea.qml

Closed

QTBUG-119646 [Tests] Warnings in qtdeclarative/tests/auto/quickcontrols/controls/data/tst_textfield.qml

Closed

QTBUG-119647 [Tests] Warnings in qtdeclarative/tests/auto/quickcontrols/controls/data/tst_tumbler.qml

Closed

QTBUG-119756 [Tests] Warnings in tst_controls::macOS::SpinBox

Closed

QTBUG-124201 [Tests] Warnings in tst_controls::Windows::SpinBox

Closed

QTBUG-124275 [Tests] Warnings in tst_controls::iOS::RangeSlider

Closed

QTBUG-124290 [Tests] Warnings in tst_controls::iOS::Slider

Closed

QTBUG-125580 [Tests] Warnings in tst_controls::Material::ComboBox::test_comboBoxWithShaderEffect()

Closed

is blocked by

QTBUG-104778 No MTLDevice warning in some auto tests

Closed

relates to

QTBUG-70029 Provide API to fail a test if a warning occurs

Closed

(11 depends on, 1 is blocked by, 1 relates to)

- Issue Only
- Show All Reviews
- Show Open Reviews

For Gerrit Dashboard: QTBUG-98718
#	Subject	Branch	Project	Status	CR	V
519074,7	tst_dial: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
519464,3	tst_action: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
519465,2	tst_actiongroup: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
519597,2	tst_abstractbutton: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
519807,2	tst_actiongroup: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
519929,2	tst_busyindicator: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
519930,2	tst_button: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
519932,2	tst_buttongroup: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
519985,2	tst_actiongroup: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520124,5	tst_container: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
520146,2	tst_button: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520147,2	tst_busyindicator: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520148,2	tst_buttongroup: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520293,2	tst_calendarmodel: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
520295,2	tst_checkbox: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
520296,2	tst_checkdelegate: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
520366,2	tst_busyindicator: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520367,2	tst_button: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520368,2	tst_buttongroup: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520484,2	tst_dial: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520497,2	tst_calendarmodel: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520577,2	tst_control: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
520604,1	tst_dial: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: ABANDONED	0	0
520617,2	tst_action: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520619,2	tst_checkdelegate: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520620,2	tst_checkbox: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520625,2	tst_calendarmodel: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520634,2	tst_container: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520635,2	tst_control: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
520794,2	tst_checkdelegate: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520795,2	tst_action: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520796,2	tst_checkbox: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520872,2	tst_container: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
520873,2	tst_control: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521256,2	tst_dayofweekrow: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521257,2	tst_delaybutton: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521258,2	tst_dialog: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521259,6	tst_dialogbuttonbox: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521260,2	tst_frame: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521301,2	tst_groupbox: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521302,2	tst_itemdelegate: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521303,2	tst_menuitem: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521304,2	tst_monthgrid: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521305,2	tst_label: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521662,2	tst_dayofweekrow: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521664,2	tst_frame: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521666,2	tst_dialog: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521667,2	tst_delaybutton: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521668,2	tst_groupbox: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521726,2	tst_dayofweekrow: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521727,2	tst_delaybutton: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521728,2	tst_dialog: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521730,2	tst_frame: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521732,2	tst_groupbox: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521737,2	tst_itemdelegate: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521738,2	tst_monthgrid: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521739,2	tst_menuitem: fail on warnings	6.6	qt/qtdeclarative	Status: MERGED	+2	0
521914,2	tst_menuitem: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521915,2	tst_monthgrid: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521916,2	tst_itemdelegate: fail on warnings	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
521932,2	tst_page: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521933,2	tst_pageindicator: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521934,2	tst_pane: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
521935,5	tst_popup: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	+1
521936,2	tst_progressbar: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522221,2	tst_radiobutton: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522242,2	tst_radiodelegate: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522243,3	tst_rangeslider: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522244,2	tst_roundbutton: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522699,2	tst_scrollbar: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522700,2	tst_scrollindicator: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522701,2	tst_scrollview: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522742,2	tst_selectionrectangle: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522743,4	tst_slider: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522748,3	tst_spinbox: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522749,4	tst_splitview: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522750,3	tst_stackview: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522751,2	tst_swipedelegate: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522752,2	tst_swipeview: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522753,2	tst_switch: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522754,2	tst_switchdelegate: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522755,8	tst_combobox: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	+1
522756,2	tst_tabbar: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522757,2	tst_tabbutton: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522758,3	tst_textarea: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522759,3	tst_textfield: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522760,2	tst_toolbar: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522761,2	tst_toolbutton: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522802,2	tst_toolseparator: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522803,2	tst_tooltip: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
522804,4	tst_tumbler: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	+1
522805,2	tst_weeknumbercolumn: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	0
554522,2	tst_spinbox: fail on warnings	6.7	qt/qtdeclarative	Status: MERGED	+2	0
568541,2	tst_tumbler: fail on warnings	6.8	qt/qtdeclarative	Status: MERGED	+2	0
633318,5	tst_Snippets: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	+1
633943,2	tst_Snippets: fail on warnings	6.9	qt/qtdeclarative	Status: MERGED	+2	0
634025,2	tst_Snippets: fail on warnings	6.8	qt/qtdeclarative	Status: MERGED	+2	0
665201,3	tst_qquickmenu: fail on warnings	dev	qt/qtdeclarative	Status: MERGED	+2	+1
676461,1	tst_qquickmenu: fail on warnings	6.10	qt/qtdeclarative	Status: DEFERRED	+2	0
680657,2	Revert "tst_qquickmenu: fail on warnings"	dev	qt/qtdeclarative	Status: MERGED	+2	0