Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-98804

Move emit callbackReceived signal after returning response to client



    • Suggestion
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • 6.2.1
    • None


      The response data to client is sent after emitting QOAuthHttpServerReplyHandler::callbackReceived signal. The problem with this approach that I noticed is that if I listen for QOAuth2AuthorizationCodeFlow::error signal, it doesn't return the client any response on browser until all slots connected to the error signal have been processed. I use the error signal to show a simple message to the user incase there was any authorization error, but the browser is kept in a loading state without receiving any response until the user dismisses the message dialog informing of an error. I think it would be better to move the QOAuthHttpServerReplyHandler::callbackReceived signal after returning a response data. As a result, client side error processing can be done without having to worrying about client timing out waiting for a response.


      EDIT: This issue is related to the reply handler class QOAuthHttpServerReplyHandler.


        No reviews matched the request. Check your Options in the drop-down menu of this sections header.



            vuokko Juha Vuolle
            exhumer Nadim Asaduzzaman
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            0 Vote for this issue
            2 Start watching this issue



              Gerrit Reviews

                There are no open Gerrit changes