Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-98804

Move emit callbackReceived signal after returning response to client

    XMLWordPrintable

    Details

    • Type: Suggestion
    • Status: Reported
    • Priority: Not Evaluated
    • Resolution: Unresolved
    • Affects Version/s: 6.2.1
    • Fix Version/s: None
    • Labels:
      None

      Description

      The response data to client is sent after emitting QOAuthHttpServerReplyHandler::callbackReceived signal. The problem with this approach that I noticed is that if I listen for QOAuth2AuthorizationCodeFlow::error signal, it doesn't return the client any response on browser until all slots connected to the error signal have been processed. I use the error signal to show a simple message to the user incase there was any authorization error, but the browser is kept in a loading state without receiving any response until the user dismisses the message dialog informing of an error. I think it would be better to move the QOAuthHttpServerReplyHandler::callbackReceived signal after returning a response data. As a result, client side error processing can be done without having to worrying about client timing out waiting for a response.

       

      EDIT: This issue is related to the reply handler class QOAuthHttpServerReplyHandler.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            jefernan Jesus Fernandez
            Reporter:
            exhumer Nadim Asaduzzaman
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes