Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-98886

QPdfDestination is used as base class, but dtor is public and non-virtual

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P0: Blocker
    • 6.4.0 Beta1
    • None
    • PDF
    • None
    • cb775365eb (qt/qtwebengine/dev)

    Description

      Base class dtors should be either protected and non-virtual or else public and virtual. This here construct is not tolerable, as it allows slicing. Make up our minds whether QPdfDestination needs to be a public baseclass or cannot be a private or protected one.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. QTBUG-77511 provide the ability to click links within a PDF

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          split from

          Task - A task that needs to be done. QTBUG-98796 Review QtPdf API before committing to BC

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              srutledg Shawn Rutledge
              mmutz Marc Mutz
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes