Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-98943

QMultiHash recursive emplace on VS2019

    XMLWordPrintable

Details

    • Windows
    • 9c13ae4fe7 (qt/qtbase/6.2) 9c13ae4fe7 (qt/tqtc-qtbase/6.2)

    Description

      The emplace function for QHash includes a workaround for VS2019.

      See: https://github.com/qt/qtbase/blob/dev/src/corelib/tools/qhash.h#L1225

      The same workaround is needed for QMultiHash as well.

      https://github.com/qt/qtbase/blob/dev/src/corelib/tools/qhash.h#L1834

      Otherwise Visual Studio 2019 will produce a warning and endlessly recursive functions:

      D:\a\qt-creator\Qt\6.2.2\msvc2019_64\include\QtCore\qhash.h(1735) : warning C4717: 'QMultiHash<Core::Internal::EditorView *,Core::IEditor *>::emplace<Core::IEditor * const &>': recursive on all control paths, function will cause runtime stack overflow

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-95880 Endless recursion in QMultiHash

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              manordheim Mårten Nordheim
              arbmind Andreas Reischuck
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes