Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-99291

As a user of QStringBuilder, I would like the system to pin down rvalues, like QStringTokenizer does

    XMLWordPrintable

Details

    Description

      In our projects, we use the AAA (almost-always auto) style, which gives us trouble when we enable QStringBuilder:

      // without QStringBuilder:
auto s2 = s + QString::fromLatin1("foo"); // ok, s2 is a QString
label.setText(s2);
// with QStringBuilder
auto s2 = s + QString::fromLatin1("foo"); // oops, s2 is a QStringBuilder<QString, QString>
// temporary returned fromLatin1() destroyed now
label.setText(s2); // conversion to actual QString here, accesses deleted data

      I like how QStringTokenizer doesn't have this problem, and I think the same technique used there can also be used in QStringBuilder.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-47066 Segmentation fault with QStringBuilder

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-87603 Crash when concatenating two strings using QT_USE_QSTRINGBUILDER

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-104354 Document QStringBuilder's auto gotcha

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Suggestion - Public suggestions QTBUG-103090 Make QStringBuilder mandatory

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open

          Suggestion - Public suggestions QTBUG-74873 Make QStringBuilder default on Qt6

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-99291
          # Subject Branch Project Status CR V
          479775,16 QStringBuilder: allow to be used with 'auto' keyword dev qt/qtbase Status: MERGED +2 0

          Activity

            People

              vladimirbelyavsky Vladimir Belyavsky
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes