Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Done
Priority: P3: Somewhat important
Fix Version/s: 6.4.0 RC1, 6.5.0 Beta1, 6.6.0
Affects Version/s: 6.2.2
Component/s: GUI: High-DPI
Labels:
None

Commits:
1c0a56a2f3 (qt/qtbase/dev) 1c0a56a2f3 (qt/tqtc-qtbase/dev) be3f589d17 (qt/qtbase/6.4) be3f589d17 (qt/tqtc-qtbase/6.4), 9a39b3c79 (dev)

Description

QT_SCREEN_SCALE_FACTORS doesn't seem to follow rounding policy, is this on a reason? This variable is used by KDE to set per-screen scale factor, so if an app can't handle fractional scale factors, it will look really ugly in such environment.

The fix is as simple as

diff --git a/src/gui/kernel/qhighdpiscaling.cpp b/src/gui/kernel/qhighdpiscaling.cpp
index 996eed40cb..1b9a7929bf 100644
--- a/src/gui/kernel/qhighdpiscaling.cpp
+++ b/src/gui/kernel/qhighdpiscaling.cpp
@@ -632,13 +632,13 @@ qreal QHighDpiScaling::screenSubfactor(const QPlatformScreen *screen)
         if (auto qScreen = screen->screen()) {
             auto screenFactor = qScreen->property(scaleFactorProperty).toReal(&screenPropertyUsed);
             if (screenPropertyUsed)
-                factor = screenFactor;
+                factor = roundScaleFactor(screenFactor);
         }
 
         if (!screenPropertyUsed) {
             auto byNameIt = QHighDpiScaling::m_namedScreenScaleFactors.constFind(screen->name());
             if ((screenPropertyUsed = byNameIt != QHighDpiScaling::m_namedScreenScaleFactors.cend()))
-                factor = *byNameIt;
+                factor = roundScaleFactor(*byNameIt);
         }
     }