Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-10555

Refactor -> Add definition in 'file.cpp' gives wrong result with r-value (rvalue) reference.

    XMLWordPrintable

Details

    • a1c18d9e971069d8e12c7becf1cf8794c9e18cc2

    Description

      src.h:

      struct Foo
{
    Foo( Foo&& );
}

      Refactor -> Add definition in 'file.cpp' gives:

      Foo::Foo(Foo&)
{
	
}

      First, rvalue reference become lvalue.
      Second, coding format is broken, it should keep all spaces in their original places:

      Foo::Foo( Foo&& )
{
	
}

      Attachments

        Issue Links

          replaces

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-10164 Apply signature changes does not work for universal (rvalue) references

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-10997 "Add Definition" fails when invoked on move-constructor or move-assignment operators.

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-6221 Add Definition doesn't understand r-value references

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTCREATORBUG-10555
          # Subject Branch Project Status CR V
          72482,1 TypeRewriter: Handle rvalue references correctly 3.0 qt-creator/qt-creator Status: ABANDONED -2 0
          73099,2 TypeRewriter: Handle rvalue references correctly master qt-creator/qt-creator Status: MERGED +2 0

          Activity

            People

              kosjar Nikolai Kosjar
              shiftz Andrew Shevchenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes